Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong PPO Model architecture. #26

Open
alirezakazemipour opened this issue Oct 6, 2020 · 2 comments
Open

Wrong PPO Model architecture. #26

alirezakazemipour opened this issue Oct 6, 2020 · 2 comments

Comments

@alirezakazemipour
Copy link

alirezakazemipour commented Oct 6, 2020 •
edited
Loading

According to the DQN nature paper and PPO1 implementation, this line:

X = activ(conv(X, 'c3', nf=64, rf=4, stride=1, init_scale=np.sqrt(2), data_format=data_format))

should be changed to:

X = activ(conv(X, 'c3', nf=64, rf=3, stride=1, init_scale=np.sqrt(2), data_format=data_format))

In short, kernel size is wrong!
@xiaioding
Copy link

这两行有什么区别？

@alirezakazemipour
Copy link
Author

@xiaioding
The difference is in kernel sizes (rf.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alirezakazemipour @xiaioding