From d0a26489fcca2f2273c9dd1289a476a1fb0643a2 Mon Sep 17 00:00:00 2001 From: Austin Vazquez Date: Mon, 12 Feb 2024 00:07:27 +0000 Subject: [PATCH 1/2] Rename unused parameters to resolve linter warnings Signed-off-by: Austin Vazquez --- pkg/pwalk/pwalk_test.go | 2 +- pkg/pwalkdir/pwalkdir_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/pwalk/pwalk_test.go b/pkg/pwalk/pwalk_test.go index b026681..66f6def 100644 --- a/pkg/pwalk/pwalk_test.go +++ b/pkg/pwalk/pwalk_test.go @@ -73,7 +73,7 @@ func TestWalkDirManyErrors(t *testing.T) { max := uint32(total / 2) e42 := errors.New("42") err := Walk(dir, - func(p string, i os.FileInfo, _ error) error { + func(_ string, _ os.FileInfo, _ error) error { if atomic.AddUint32(&count, 1) > max { return e42 } diff --git a/pkg/pwalkdir/pwalkdir_test.go b/pkg/pwalkdir/pwalkdir_test.go index 0096638..35e7655 100644 --- a/pkg/pwalkdir/pwalkdir_test.go +++ b/pkg/pwalkdir/pwalkdir_test.go @@ -76,7 +76,7 @@ func TestWalkDirManyErrors(t *testing.T) { max := uint32(total / 2) e42 := errors.New("42") err := Walk(dir, - func(p string, e fs.DirEntry, _ error) error { + func(_ string, _ fs.DirEntry, _ error) error { if atomic.AddUint32(&count, 1) > max { return e42 } From 8d30f36ad8b9e9eeddc0049500f9e8d6439c6c9a Mon Sep 17 00:00:00 2001 From: Austin Vazquez Date: Sun, 11 Feb 2024 23:59:35 +0000 Subject: [PATCH 2/2] Update GitHub Actions CI Go matrix for Go v1.22 This change adds Go v1.22 to the GitHub Actions CI matrix and drops Go v1.19 and v1.20 which would no longer receive updates. Also it updates the golangci-lint version to v1.56 which adds support for Go v1.22. Signed-off-by: Austin Vazquez --- .github/workflows/validate.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 9e7544e..bf1ad4f 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -33,11 +33,11 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: 1.21.x + go-version: 1.22.x cache: false # golangci-lint-action does its own caching - uses: golangci/golangci-lint-action@v3 with: - version: v1.54 + version: v1.56 codespell: runs-on: ubuntu-22.04 @@ -62,11 +62,11 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: 1.21.x + go-version: 1.22.x cache: false # golangci-lint-action does its own caching - uses: golangci/golangci-lint-action@v3 with: - version: v1.54 + version: v1.56 - name: test-stubs run: make test @@ -74,7 +74,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.19.x, 1.20.x, 1.21.x] + go-version: [1.21.x, 1.22.x] race: ["-race", ""] runs-on: ubuntu-20.04 steps: