Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boto-based exceptions from bulk_email #31779

Closed
Tracked by #31175
awais786 opened this issue Feb 16, 2023 · 4 comments
Closed
Tracked by #31175

Replace boto-based exceptions from bulk_email #31779

awais786 opened this issue Feb 16, 2023 · 4 comments

Comments

@awais786
Copy link
Contributor

awais786 commented Feb 16, 2023

Context

We are currently removing the usage of boto from the edx-platform as boto isn't supported anymore. So we are shifting anything that currently uses boto to use boto3. The following files are importing exceptions from boto which should now be used from botocore.

Files

Exceptions

from boto.exception import AWSConnectionError
from boto.ses.exceptions import (
    SESAddressBlacklistedError,
    SESAddressNotVerifiedError,
    SESDailyQuotaExceededError,
    SESDomainEndsWithDotError,
    SESDomainNotConfirmedError,
    SESIdentityNotVerifiedError,
    SESIllegalAddressError,
    SESLocalAddressCharacterError,
    SESMaxSendingRateExceededError
)

A/C

  • Remove usage of boto from the above-mentioned files.
@awais786
Copy link
Contributor Author

boto/boto3#2342

@awais786
Copy link
Contributor Author

awais786 commented Feb 19, 2023

django-ses has removed usage of boto in this PR.

edx is using latest version of django-ses so it means boto.ses.exceptions are not functional. Need to verify this on splunk or newrelic also.

@awais786
Copy link
Contributor Author

@iamsobanjaved
Copy link
Contributor

As per the above comments and logs checking from Splunk, we think these exceptions are neither being raised nor being caught now. So we did an effort to replace these exceptions with ones that we think should be raised now. We still need a review from owning squad on this.

PR: #31827

@iamsobanjaved iamsobanjaved changed the title bulk_email change boto exceptions from this module Replace boto-based exceptions from bulk_email Mar 14, 2023
@awais786 awais786 closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants