-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew test block fails with 0.4.18c #175
Comments
Derek add label: bug |
Thanks @ilovezfs. @alexellis we should have a look at ensuring the brew test is also executed as part of CI here to prevent this happening again in future. |
That would be great! :) |
@ilovezfs I don't suppose you've come across any existing projects that already do so? Ideally I'd like to be able to run the same tests in both |
Not off the top of my head but something like this is probably still viable https://stackoverflow.com/questions/20396325/using-travis-ci-to-test-homebrew-tap |
You could also just run test-bot. See |
@ilovezfs @alexellis has unblocked things for the moment with #174 and a bumped release at Homebrew/homebrew-core#19508 |
Thanks for the fix. Please let me know if you run into any problems with getting |
Expected Behaviour
The test block to pass, as it does with 0.4.18b
Current Behaviour
The test block fails.
Possible Solution
Steps to Reproduce (for bugs)
https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/11005/version=high_sierra/testReport/junit/brew-test-bot/high_sierra/test_faas_cli/
Context
Trying to upgrade the Homebrew formula to 0.4.18c: Homebrew/homebrew-core#19499
Your Environment
Docker version
docker version
(e.g. Docker 17.0.05 ):N/A
Are you using Docker Swarm or Kubernetes (FaaS-netes)?
N/A
Operating System and version (e.g. Linux, Windows, MacOS):
macOS
Link to your project or a code example to reproduce issue:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/faas-cli.rb#L31-L82
The text was updated successfully, but these errors were encountered: