Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Ingest/Manage your data” toggle #774

Open
adaisley opened this issue Sep 9, 2021 · 3 comments
Open

“Ingest/Manage your data” toggle #774

adaisley opened this issue Sep 9, 2021 · 3 comments
Labels

Comments

@adaisley
Copy link

adaisley commented Sep 9, 2021

Hi,

We are currently running an OpenDistro docker set up and are looking to move to OpenSearch&OSD soon. We would usually build our own version of Kibana from source with some logo changes, favicons etc., all which have plans to be customisable in future versions of OSD, which I’m aware of.

One thing we also like to do is strip out things that aren’t particularly useful for our end users. We run a service where several clients can access their own tenant within Kibana, and basically just view pre-made dashboards, or if they’re knowledgable with Kibana, create their own, but that isn’t a requirement. Everything in our set up tends to be ready-to-use.

Is your feature request related to a problem? Please describe.

We find it a little frustrating having to build our own version of OSD just to remove some things that really shouldn't be visible to the end-users of OSD. The main thing we'd like to remove, either by config or a toggle, is the "Ingest/Manage your data" section visible in /app/home/ and /app/opensearch_dashboards_overview/ as seen below:

image

We don't think that this is something that end-users should have access to see, as it may cause confusion/issues. As for admin accounts specified in the security configuration, this could remain visible, or entirely disappear as there are other methods of achieving the same objective that the buttons are trying to achieve.

Describe the solution you'd like

We would like to see some kind of option (either by config or by a toggle) that removes the aforementioned sections of OSD. Ideally, it might still be available for users who have an admin role, but there’s also plenty of other ways to achieve what those buttons are trying to achieve that they might not be necessary.

We've previously achieved this by just deleting some code in the following files of our OpenDistro Kibana repo:
src/plugins/home/public/application/components/home.js
src/plugins/home/public/application/components/home.test.js
src/plugins/kibana_react/public/overview_page/overview_page_footer/overview_page_footer.tsx
src/plugins/kibana_react/public/overview_page/overview_page_header/overview_page_header.tsx

Just removing the sections of code obviously wouldn't suffice to make this toggle-able, but at least these are the files that are responsible for the code.

Describe alternatives you've considered

As mentioned by searchymcsearchface in the forums link below, an alternative solution is that this is something that could be hidden with CSS if there was a way to add custom styles.

Additional context

https://discuss.opendistrocommunity.dev/t/osd-ingest-manage-your-data-toggle/6949

@adaisley adaisley added the enhancement New feature or request label Sep 9, 2021
@tmarkley
Copy link
Contributor

tmarkley commented Sep 9, 2021

Thanks for submitting this idea! This seems fairly complex considering it would likely require editing routes based on roles. I don't think that custom styles would solve this problem since the styles wouldn't be applied for all roles.

@kgcreative @ahopp what do you think?

@ahopp
Copy link
Contributor

ahopp commented Sep 21, 2021

In general, I like added configuration but I think we'll need to align on a consistent pattern for this type of config since this pattern will be reused for other config options outside just this examples. I also agree that the user/role based configuration adds some complexity relative to current configuration options.

@adaisley I like the idea of having the feature "entirely disappear" as a first version for the sake of simplification but I think there are plenty of use cases for user/role UI/feature configuration for Dashboards. Even paths to other advance feature might be something that downstream users (like yourself) might want to have the option to suppress. Given that, I'd propose the following;

  1. Version 1: Start with configuration path for some features that suppresses for all users in the UI.
  2. Version 2: Build in role based configuration for the feature configurable in v1.
  3. Version X: Add more configuration options as they are identified by the community.

As long as this options don't impact those that don't need to suppress feature, I think there is a lot we can do to make it easy to configure OpenSearch Dashboards.

@ahopp
Copy link
Contributor

ahopp commented Sep 23, 2021

Might be worth some eyes on @kgcreative since it'll need a UI/UX proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants