hack/build.sh no longer builds oc-mirror

[jharmison-redhat]

Version

Any with 24788de

What happened?

$ hack/build.sh --clean
#############################################
# clean, tidy, and test-unit output trimmed #
#############################################
go build -tags 'json1 -mod=vendor' -ldflags="-X k8s.io/component-base/version.gitMajor="0" -X k8s.io/component-base/version.gitMinor="2" -X k8s.io/component-base/version.gitVersion="v0.2.0-alpha.1" -X k8s.io/component-base/version.gitCommit="" -X k8s.io/component-base/version.buildDate="2022-03-18T14:02:47Z" -X k8s.io/component-base/version.gitTreeState="clean" -X k8s.io/client-go/pkg/version.gitVersion="" -X k8s.io/client-go/pkg/version.gitCommit="" -X k8s.io/client-go/pkg/version.buildDate="2022-03-18T14:02:47Z" -X k8s.io/client-go/pkg/version.gitTreeState=""" -o bin/oc-mirror ./cmd/oc-mirror
go: missing Git command. See https://golang.org/s/gogetcmd
error obtaining VCS status: exec: "git": executable file not found in $PATH
	Use -buildvcs=false to disable VCS stamping.
make: *** [Makefile:28: build] Error 1
>>  ERROR: Failed to build binary

What did you expect to happen?

$ hack/build.sh --clean
#############################################
# clean, tidy, and test-unit output trimmed #
#############################################
go build -tags 'json1 -mod=vendor' -ldflags="-X k8s.io/component-base/version.gitMajor="0" -X k8s.io/component-base/version.gitMinor="2" -X k8s.io/component-base/version.gitVersion="v0.2.0-alpha.1" -X k8s.io/component-base/version.gitCommit="35aa8e2807c6529406ae9a85987533cf53eb3478" -X k8s.io/component-base/version.buildDate="2022-03-18T14:08:21Z" -X k8s.io/component-base/version.gitTreeState="clean" -X k8s.io/client-go/pkg/version.gitVersion="" -X k8s.io/client-go/pkg/version.gitCommit="35aa8e2807c6529406ae9a85987533cf53eb3478" -X k8s.io/client-go/pkg/version.buildDate="2022-03-18T14:08:21Z" -X k8s.io/client-go/pkg/version.gitTreeState=""" -o bin/oc-mirror ./cmd/oc-mirror
>>  INFO: Successfully built binary

How to reproduce it (as minimally and precisely as possible)?

$ hack/build.sh --clean

Anything else we need to know?

git is not in the Dockerfile

References

• Introduced in Bug 2058267: Add clarifying information to oc-mirror version command and remove alpha.3 from semver #334
• Dockerfile entrypoint is make
• Makefile target for build expands the variables that include shell calls for git