Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify transmission of directory listings? #36

Open
rafpaf opened this issue Dec 24, 2022 · 6 comments
Open

Clarify transmission of directory listings? #36

rafpaf opened this issue Dec 24, 2022 · 6 comments
Labels
good first issue Good for newcomers

Comments

@rafpaf
Copy link

rafpaf commented Dec 24, 2022

Thank you for this fantastic piece of software!

I appreciated seeing the thoughtful note in your README about sensitive information. I saw this line:

If you are concerned about the potential for sensitive information to be sent to OpenAI, we recommend not using these flags [i.e. --alias, --git, --history, etc.].

This made me think that no sensitive information would be transmitted to OpenAI if I avoided those flags. However, when I run terminal-copilot with the -v flag, I can see that it transmits a listing of the current directory as part of the prompt. You could clarify that this transmission will happen, even if no special flags are used. It might also be useful to let users disable this transmission. Another reason it is sometimes useful to disable this feature is that if the directory listing is very long, it can lead to an unexpected openai.error.InvalidRequestError.

@github-actions
Copy link

Hey! Thanks for sharing feedback with the community!

@JoelKronander
Copy link
Collaborator

Good point, we should probably make this optional as some form of config setting.

@JoelKronander JoelKronander added the good first issue Good for newcomers label Jan 25, 2023
@rafpaf
Copy link
Author

rafpaf commented Jan 25, 2023

For what it's worth, for now I'm using terminal-copilot via a script that always runs it from an empty directory in /tmp.

It's a very useful command. Thank you again.

@JoelKronander
Copy link
Collaborator

@rafpaf Want to try to make a small PR to make it more like you would prefer it to be? Eg. making the directory listing optional? or asking the user the first time to include it or not?

@JoelKronander
Copy link
Collaborator

@rafpaf Any other thoughts on how we can make the tool even better?

@2mawi2
Copy link
Contributor

2mawi2 commented Mar 19, 2023

@rafpaf Could you test for me if your script use-case works with #43 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants