[openwrt] Missing zonename attribute

[nemesifier]

The OpenWrt backend does not generate the zonename attribute.

[ritwickdsouza]

What is zonename ? Is it different from timezone? Could you give a sample code for generating the bug.

[nemesifier]

@ritwickdsouza look in the OpenWRT docs: https://wiki.openwrt.org/doc/uci/system; to replicate the bug write a test in which you assert for the presence of the zonename attribute. The value should be generated from timezone.

[ritwickdsouza]

So whenever timezone attribute is defined. Both timezone and zonename must be rendered. Right ?

[nemesifier]

Yes

[ritwickdsouza]

Could you help point out where exactly the output generated and places where changes needs to be made ? I'm having some trouble understanding the codebase.

[nemesifier]

@ritwickdsouza: https://github.com/openwisp/netjsonconfig/blob/master/netjsonconfig/backends/openwrt/renderers.py#L265-L277

[nemesifier]

I suggest you to write a failing test first (Test Driven Development), you have to add it to this file:
https://github.com/openwisp/netjsonconfig/blob/master/tests/openwrt/test_system.py

See the documentation regarding how to run tests.

[nemesifier]

Fixed by #65