Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openwrt] Drop "enabled" logic in OpenVpnRenderer in 0.6.0 #58

Closed
nemesifier opened this issue Jan 17, 2017 · 5 comments
Closed

[openwrt] Drop "enabled" logic in OpenVpnRenderer in 0.6.0 #58

nemesifier opened this issue Jan 17, 2017 · 5 comments

Comments

@nemesifier
Copy link
Member

Solve the issues explained by the comments marked as TODO in 7a152a3.
@jack17529
Copy link

@nemesisdesign ok sir I will solve them.

@nemesifier
Copy link
Member Author

@jack17529 I did not specify that this must be done in the 0.6.0 release, not now. It's a reminder for a minor cleanup. Thanks anyway.

@nemesifier nemesifier changed the title [openwrt] Drop "enabled" logic in OpenVpnRenderer [openwrt] Drop "enabled" logic in OpenVpnRenderer in 0.6.0 Mar 21, 2017
@jack17529
Copy link

@nemesisdesign so should I not touch the code?

@nemesifier
Copy link
Member Author

@jack17529 no it's not needed. I'll take care of it. I suggest you to find ways to contribute that are more useful to us. Stuff I don't have time to do, finding new bugs. Triaging tickets. Whatever you can do to help out.

@jack17529
Copy link

@nemesisdesign roger that .

nemesifier added a commit that referenced this issue May 25, 2017
@nemesifier
[openwrt] Dropped obsolete code in OpenVpn backend #58
a402079 
Closes #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemesifier @jack17529