Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize easy to copy uuid, secret key and secret URL logic #40

Closed
nemesifier opened this issue Mar 23, 2019 · 3 comments · Fixed by #71
Closed

Generalize easy to copy uuid, secret key and secret URL logic #40

nemesifier opened this issue Mar 23, 2019 · 3 comments · Fixed by #71
Labels
enhancement

Comments

@nemesifier
Copy link
Member

nemesifier commented Mar 23, 2019 •
edited
Loading

Reserved for GSoC Students

We have different parts of different OpenWISP modules which have a key or secret field which has one or more of the following features:

We need to:

  • remove the duplication of this logic across modules and make it reusable
  • add automated tests for this logic
  • document its usage briefly in the README of this module
  • update the other modules to use the generalized solution here in openwisp-utils
@NoumbissiValere
Copy link
Contributor

Let me take a look at this

NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 21, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
7515925 
Removed the logics which were duplicated
in the others modules and redefined it here to enable reusability and ease debugging.

Fixes openwisp#40
@NoumbissiValere NoumbissiValere mentioned this issue Apr 21, 2019
Closed
NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 21, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
458fa39 
Removed the logics which were duplicated
in the others modules and redefined it
here to enable reusability and ease debugging.

Fixes openwisp#40
NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 21, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
7e4e409 
Removed the logics which were duplicated
in the others modules and redefined it
here to enable reusability and ease debugging.

Fixes openwisp#40
NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 21, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
bb8dd77 
Removed the logics which were duplicated
in the others modules and redefined it
here to enable reusability and ease debugging.

Fixes openwisp#40
@NoumbissiValere
Copy link
Contributor

@nemesisdesign please should i still remove the receive_url logic from django-netjsongraph and define it in openwisp-utils even though it is only defined here?

@nemesifier
Copy link
Member Author

@NoumbissiValere it's ok now to leave django-netjsongraph, if we find out we need to reuse that code (eg: shared templates in openwisp-controller need to show the URL to users so they can copy it) we will do the same work there as well

NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 24, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
1d51200 
Removed the logics which were duplicated
in the others modules and redefined it
here to enable reusability and ease debugging.

Fixes openwisp#40
NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 24, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
1a5ac0a 
Removed the logics which were duplicated
in the others modules and redefined it
here to enable reusability and ease debugging.

Fixes openwisp#40
NoumbissiValere added a commit to NoumbissiValere/openwisp-utils that referenced this issue Apr 24, 2019
@NoumbissiValere
[admin] Removed logic duplicates openwisp#40
6506253 
Removed the logics which were duplicated
in the others modules and redefined it
here to enable reusability and ease debugging.

Fixes openwisp#40
This was referenced Jan 11, 2020
Merged
Merged
Merged
Merged
Merged
Merged
nemesifier added a commit that referenced this issue Jan 20, 2020
@nemesifier
Merge pull request #71 from waleko/issues/40
efcb6bc 
[admin] Removed logic duplicates #40
nemesifier added a commit to openwisp/django-netjsongraph that referenced this issue Jan 22, 2020
@nemesifier
Merge pull request #109 from waleko/master
d47b251 
[django] Generalize uuid/key/receive_url logic (openwisp/openwisp-utils#40)
nemesifier added a commit to openwisp/django-netjsonconfig that referenced this issue Jan 22, 2020
@nemesifier
Merge pull request #143 from waleko/master
d5cae30 
[django] Generalize uuid/key logic openwisp/openwisp-utils#40
nemesifier added a commit to openwisp/openwisp-users that referenced this issue Jan 22, 2020
@nemesifier
Merge pull request #99 from waleko/master
02b90fd 
[django] Generalize uuid logic (openwisp/openwisp-utils#40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
OpenWISP Contributor's Board
Archived in project
Milestone
No milestone
2 participants
@nemesifier @NoumbissiValere