Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to handle ServerRequest and ServerResponse public types #33

Open
codefromthecrypt opened this issue May 20, 2020 · 1 comment
Open

how to handle ServerRequest and ServerResponse public types #33

codefromthecrypt opened this issue May 20, 2020 · 1 comment

Comments

@codefromthecrypt
Copy link

ServerRequest and ServerResponse types are public, so I'm not sure how we should handle them. I'm not sure if they are public as a part of the api, or accidentally so.

I'd like to migrate this to latest brave, but adhering to these might make things a bit more difficult than if they never exists or were package private..
@codefromthecrypt
Copy link
Author

@beckje01 do you all use these internally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt