Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better error handling when github rate limit reached #797

Open
gberl002 opened this issue Jul 15, 2022 · 0 comments
Open

Need better error handling when github rate limit reached #797

gberl002 opened this issue Jul 15, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@gberl002
Copy link
Contributor

During express install, there are a few calls to github (I believe two per default install and more if you set a specific version to download). Github's API has a default rate limit of 60 calls per hour and, if reached, the ziti install will return null as the ZITI_BINARIES_VERSION to be downloaded.

This install will continue to try and download with the null value, we should add a check for the version and halt the install while explaining what the issue may be and how to check.

With regards to how to check:
Run this command: curl -I https://api.github.com/users/octocat
And read the x-ratelimit-remaining field.
If the remaining calls is 0 then copy the value from the x-ratelimit-reset field and use a converter (such as http://www.epochconverter.com/) to find out when it will reset and more install attempts can be made.

This shouldn't happen often but we should provide better feedback to the user in the event that this does occur.

@gberl002 gberl002 added enhancement New feature or request good first issue Good for newcomers labels Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant