Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP-only controller adds IP to DNS of SANS #811

Open
dovholuknf opened this issue Aug 7, 2022 · 1 comment
Open

IP-only controller adds IP to DNS of SANS #811

dovholuknf opened this issue Aug 7, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest quickstart

Comments

@dovholuknf
Copy link
Member

user on discourse had a problem adding a second router to an "IP only" quickstart install. See discourse for details https://openziti.discourse.group/t/creating-certs-for-a-remote-private-router/694/8

It looks like when the environment doesn't have an external DNS (AWS does, OCI does not) and you set the external_dns to the external_ip, the cert that is generated will (of course) have an IP address added as a DNS entry. If the external_dns == the external_ip, we should not add the IP address as a DNS entry in the sans
@dovholuknf dovholuknf added bug Something isn't working quickstart labels Aug 7, 2022
@dovholuknf dovholuknf added the good first issue Good for newcomers label Sep 16, 2022
@gberl002 gberl002 mentioned this issue Sep 22, 2022
Open
@gberl002
Copy link
Contributor

Fixing #812 should fix this but double check after fixing to be sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest quickstart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dovholuknf @gberl002