Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard shops / POIs not being shown when "3D Buildings" is disabled #8444

Open
rjw62 opened this issue Jun 11, 2024 · 6 comments
Open

Standard shops / POIs not being shown when "3D Buildings" is disabled #8444

rjw62 opened this issue Jun 11, 2024 · 6 comments
Labels
Styles Map drawing styles

Comments

@rjw62
Copy link

rjw62 commented Jun 11, 2024

It seems that some standard shops are not being included/shown on the map, probably because of some other tags they do/don't possess.

In particular, most of the shops in the shopping mall in Peterbrough (UK) are not showing up on the most recent Organic Maps maps: https://www.openstreetmap.org/#map=18/52.57368/-0.24446

Screenshot_20240611_134219_Organic Maps

The shops are mapped as polygons (ways), such as

I would expect a recognised shop=* object to be shown on the map regardless of any other tagging. I'm guessing that it may be the building:part=yes tags that are keeping these shops off the map.

OrganicMaps version: 2024.06.02-12-Google on a Galaxy S10e phone running Android 12.

@Jean-BaptisteC Jean-BaptisteC added the Styles Map drawing styles label Jun 11, 2024
@dvdmrtnz
Copy link
Contributor

They are showing up just fine for me:

@rjw62
Copy link
Author

rjw62 commented Jun 11, 2024

Thanks. It seems that the difference is whether or not the OrganicMaps "3D Buildings" setting is turned on.

With "3D Buildings" on, I do indeed see those shops, as in the screenshot from @dvdmrtnz . But with "3D Buildings" off, they do not show up (as per my original screenshot).

So it looks like this is some sort of bug, just not quite the cause I was expecting...

@dvdmrtnz dvdmrtnz changed the title Standard shops / POIs not being shown Standard shops / POIs not being shown when "3D Buildings" is disabled Jun 11, 2024
@dvdmrtnz
Copy link
Contributor

dvdmrtnz commented Jun 11, 2024

You’re right, they disappear when 3D Buildings setting is disabled

@RedAuburn
Copy link
Sponsor Member

hmm, maybe because they're also tagged as building:part?

@hoizan
Copy link

hoizan commented Jun 11, 2024

Similar to #8258

@RedAuburn
Copy link
Sponsor Member

RedAuburn commented Jun 12, 2024

those have building:part too. i guess building:parts are discarded when disabling 3d buildings in order to improve performance, but as a result the amenity/shops are discarded too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styles Map drawing styles
Projects
None yet
Development

No branches or pull requests

5 participants