Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note wrongly added because snapshot's too old #8463

Open
bmallet opened this issue Jun 14, 2024 · 9 comments
Open

Note wrongly added because snapshot's too old #8463

bmallet opened this issue Jun 14, 2024 · 9 comments
Labels
Editor OSM Editor

Comments

@bmallet
Copy link

bmallet commented Jun 14, 2024

Someone contrbuted to OSM with a note (https://www.openstreetmap.org/note/4283551) saying the shop is closed, nice... but this shop has been deleted from OSM one year ago :-(
This contributor has downloaded his map in 2022-07-18 if i do understand the trouble.

I think, before sending a correction or a note to OSM, Organic Maps should check that the downloaded map is not too old, note more than two months, for example. If it's not the case, you should prevent the contribution (we do have enough notes in OSM;-).

@bmallet
Copy link
Author

bmallet commented Jun 14, 2024

Ah and by the way, thank you for this nice app which is Organic Maps, this kind of app is a good way for the people to discover OSM.

@Jean-BaptisteC
Copy link
Member

Normally if maps is too old, its not possible to edit map

@patepelo patepelo added the Editor OSM Editor label Jun 14, 2024
@patepelo
Copy link
Contributor

related to #6936 and #7930

@biodranik
Copy link
Member

Map data edits are blocked without updating maps. Posting notes is not blocked (why should it? Useful notes can come about different objects, including missing ones).

@bmallet
Copy link
Author

bmallet commented Jun 16, 2024

OK but to get useful and right comment in a note it's better if this note is written after have looked the actual map.
Case i gave in example (https://www.openstreetmap.org/note/4283551) : the organic maps contributor says a shop is closed because he has seen it opened on the map but in fact this shop has been closed in OSM on 2023-07-05 (https://www.openstreetmap.org/node/3501719732/history)
Result : a note useless
And in your example "Useful notes can come about different objects, including missing ones", same kind of trouble could occur : the organic maps contributor write a note for a "new" shop he sees but, because his map is 6 months old, this shop already exit, in fact, in the OSM database for 3 months : definitely this is not an "useful" note.
I do think that telling people who want to contribute, even with notes : "sorry, your map is too old (2 months old) ; before posting a note, please upload an actual version" would be a better way.

@biodranik
Copy link
Member

Right, this issue should be solved by promoting/forcing users to update maps. It can be done by displaying the "Update Map" button in the Place Page, and by displaying a warning/note when editing a note.

@euf @kirylkaveryn @Jean-BaptisteC is it hard to add an "Update Map" button into the Place Page? Do you have any ideas on where to put it? The first "Download" button is already displayed in PP when an empty map region is selected. Maybe always displaying update there will be annoying enough to promote map update? Then just reusing the same button/code but only use a different translation for it would be sufficient?

@euf
Copy link
Contributor

euf commented Jun 16, 2024

Actually I agree with @bmallet.
Since the editor becomes disables when the map is outdated, the same could be done for the notes.

It would be good to prompt users to update when they wish to edit / leave note. Even better would be not just showing an alert, but with giving a direct option to update maps right now.

As for the Place Page indication, I'll keep it in mind for the further PP redesigns. Not sure if it's possible to cramp it in at the moment.

@kirylkaveryn
Copy link
Contributor

Do you have any ideas on where to put it?

Maybe we can reuse the edit place button in pp?
With text "Update map to edit place".

image

And in case of Add Place we can show the alert when user try to open the "add place" with buttons: "update map" (that will opens the download screen) and "cancel" the just close an alert.

@biodranik
Copy link
Member

This is a cool idea, is it possible to display the download indicator (simplified, just text percents) in the same Edit Place button?

Regarding Add Place, we can offer an action with two items "Update now" and "Update later", WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor OSM Editor
Projects
None yet
Development

No branches or pull requests

6 participants