-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note wrongly added because snapshot's too old #8463
Comments
Ah and by the way, thank you for this nice app which is Organic Maps, this kind of app is a good way for the people to discover OSM. |
Normally if maps is too old, its not possible to edit map |
Map data edits are blocked without updating maps. Posting notes is not blocked (why should it? Useful notes can come about different objects, including missing ones). |
OK but to get useful and right comment in a note it's better if this note is written after have looked the actual map. |
Right, this issue should be solved by promoting/forcing users to update maps. It can be done by displaying the "Update Map" button in the Place Page, and by displaying a warning/note when editing a note. @euf @kirylkaveryn @Jean-BaptisteC is it hard to add an "Update Map" button into the Place Page? Do you have any ideas on where to put it? The first "Download" button is already displayed in PP when an empty map region is selected. Maybe always displaying update there will be annoying enough to promote map update? Then just reusing the same button/code but only use a different translation for it would be sufficient? |
Actually I agree with @bmallet. It would be good to prompt users to update when they wish to edit / leave note. Even better would be not just showing an alert, but with giving a direct option to update maps right now. As for the Place Page indication, I'll keep it in mind for the further PP redesigns. Not sure if it's possible to cramp it in at the moment. |
Maybe we can reuse the And in case of Add Place we can show the alert when user try to open the "add place" with buttons: "update map" (that will opens the download screen) and "cancel" the just close an alert. |
This is a cool idea, is it possible to display the download indicator (simplified, just text percents) in the same Edit Place button? Regarding Add Place, we can offer an action with two items "Update now" and "Update later", WDYT? |
Someone contrbuted to OSM with a note (https://www.openstreetmap.org/note/4283551) saying the shop is closed, nice... but this shop has been deleted from OSM one year ago :-(
This contributor has downloaded his map in 2022-07-18 if i do understand the trouble.
I think, before sending a correction or a note to OSM, Organic Maps should check that the downloaded map is not too old, note more than two months, for example. If it's not the case, you should prevent the contribution (we do have enough notes in OSM;-).
The text was updated successfully, but these errors were encountered: