From 4e3d23ad14b29832f14784939acc5afe2f1b28f8 Mon Sep 17 00:00:00 2001 From: Misty De Meo Date: Thu, 3 Nov 2016 16:52:40 -0700 Subject: [PATCH] Resource: set version to nil if version is null Is this the right fix? This fixes version cascading from the parent. --- Library/Homebrew/resource.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/resource.rb b/Library/Homebrew/resource.rb index fe18f14ddcb59..c0e9dbadaea70 100644 --- a/Library/Homebrew/resource.rb +++ b/Library/Homebrew/resource.rb @@ -145,7 +145,10 @@ def url(val = nil, specs = {}) end def version(val = nil) - @version ||= detect_version(val) + @version ||= begin + version = detect_version(val) + version.null? ? nil : version + end end def mirror(val) @@ -155,7 +158,7 @@ def mirror(val) private def detect_version(val) - return if val.nil? && url.nil? + return Version::NULL if val.nil? && url.nil? case val when nil then Version.detect(url, specs)