Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argparsing: problems with the -o, --output flag #13

Closed
vrmiguel opened this issue Apr 5, 2021 · 3 comments
Closed

Argparsing: problems with the -o, --output flag #13

vrmiguel opened this issue Apr 5, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@vrmiguel
Copy link
Member

vrmiguel commented Apr 5, 2021

Relevant branch

  • ouch file.tar.gz -o new-folder

    • Expected: create new-folder if it doesn't exist and decompress the files in there
    • What currently happens: ouch ignores the flag and saves to pwd
  • ouch file.tar.gz --output new-folder

    • Expected: ouch src.tar.lzma --output new-src
    • What currently happens: [ERROR] cannot compress to 'new-src', likely because it has an unsupported (or missing) extension.
@vrmiguel vrmiguel added the bug Something isn't working label Apr 5, 2021
@marcospb19
Copy link
Member

I'm debugging -o failing, is a problem with oof's argparsing.
When using --output argparsing works, just like -o will when we fix it, so we need to debug that too.

Probably occurs inside of Evaluator::compress_files, when calling other functions.

@marcospb19
Copy link
Member

Apparently I forgot to fix that TODO.
image

Now making the -o fix PR.

@vrmiguel
Copy link
Member Author

vrmiguel commented Apr 6, 2021

Solved by #14 and #16

@vrmiguel vrmiguel closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants