Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle Zip when modified times are missing #433

Merged
merged 1 commit into from
Jun 4, 2023
Merged

fix: handle Zip when modified times are missing #433

merged 1 commit into from
Jun 4, 2023

Conversation

marcospb19
Copy link
Member

Fixes #411.

figsoda
figsoda approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/archive/zip.rs Outdated Show resolved Hide resolved
@marcospb19 marcospb19 force-pushed the zip-ignore-archives-without-modification-time branch from bed197d to 20f3839 Compare June 4, 2023 20:19
@marcospb19 marcospb19 merged commit f3c888b into main Jun 4, 2023
3 checks passed
@marcospb19 marcospb19 deleted the zip-ignore-archives-without-modification-time branch June 4, 2023 20:19
@marcospb19
Copy link
Member Author

marcospb19 commented Jun 4, 2023 •
edited
Loading

oh, CI is failing

@figsoda
Copy link
Member

figsoda commented Jun 4, 2023

the failure seems unrelated, I think we are just running into edge case upstream bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when files in ZIP have no date
2 participants
@marcospb19 @figsoda