Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The help message does not respect NO_COLOR #62

Closed
vrmiguel opened this issue Oct 6, 2021 · 1 comment · Fixed by #95
Closed

The help message does not respect NO_COLOR #62

vrmiguel opened this issue Oct 6, 2021 · 1 comment · Fixed by #95
Labels
bug Something isn't working high priority
Milestone
0.4.0

Comments

@vrmiguel
Copy link
Member

vrmiguel commented Oct 6, 2021

No description provided.

@marcospb19 marcospb19 added bug Something isn't working high priority labels Oct 6, 2021
@marcospb19 marcospb19 added this to the 0.2.1 milestone Oct 7, 2021
@figsoda
Copy link
Member

figsoda commented Oct 15, 2021

I think a better way to do it is to initialize all the colors inside a big lazy_static! block instead of doing if *NO_COLOR_IS_SET everywhere
Also lazy_static can probably be replaced with once_cell

@figsoda figsoda mentioned this issue Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

refactor: better NO_COLOR support
3 participants
@vrmiguel @marcospb19 @figsoda