Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify colors implementation to remove code duplication #66

Closed
marcospb19 opened this issue Oct 6, 2021 · 0 comments · Fixed by #95
Closed

Simplify colors implementation to remove code duplication #66

marcospb19 opened this issue Oct 6, 2021 · 0 comments · Fixed by #95
Labels
enhancement New feature or request low priority

Comments

@marcospb19
Copy link
Member

Each color could have it's function created with a macro, the function would receive the color &str as the argument and use conditional compilation inside in an cfg!() if block, which is resolved and optimized out in compile time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: better NO_COLOR support
1 participant
@marcospb19