Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired federated share has wrong activity message on sharee activity #1116

Open
grgprarup opened this issue Jun 27, 2022 · 0 comments
Open

Comments

@grgprarup
Copy link
Contributor

grgprarup commented Jun 27, 2022

Steps to reproduce

  1. Create user Alice on the LOCAL server, and user Brian on the REMOTE server
  2. Share a file lorem.txt from user Alice to federated user Brian
  3. Accept incoming shares for federated user Brian
  4. Let it expire

Expected behaviour

It should be like, The share for 'lorem\.txt' has expired

Actual behaviour

It says, 'Alice' unshared 'lorem.txt' from you, Is this the expected behavior?

curl -k -XGET -uBrian:123456 http://localhost/fed-core/index.php/apps/activity/api/v2/activity
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": null
    },
    "data": [
      {
        "activity_id": 134,
        "type": "remote_share",
        "user": null,
        "affecteduser": "Brian",
        "app": "files_sharing",
        "subject": "remote_share_unshared",
        "subjectparams": [
          {
            "value": "Alice@http://localhost/core",
            "type": "federated_cloud_id"
          },
          {
            "value": "lorem.txt",
            "type": "base"
          }
        ],
        "message": "",
        "messageparams": [],
        "link": "",
        "object_type": "files",
        "object_id": 0,
        "object_name": "",
        "subject_prepared": "<federated-cloud-id display-name=\"Alice@…\" user=\"Alice\" server=\"http://localhost/core\">Alice@http://localhost/core</federated-cloud-id> unshared <parameter>lorem.txt</parameter> from you",
        "message_prepared": "",
        "typeicon": "icon-shared",
        "datetime": "2022-06-29T07:16:16+00:00"
      },
      {
        "activity_id": 133,
        "type": "remote_share",
        "user": null,
        "affecteduser": "Brian",
        "app": "files_sharing",
        "subject": "remote_share_received",
        "subjectparams": [
          {
            "value": "Alice@http://localhost/core",
            "type": "federated_cloud_id"
          },
          {
            "value": "lorem.txt",
            "type": "base"
          },
          {
            "value": {
              "shareId": "38"
            },
            "type": "base"
          }
        ],
        "message": "",
        "messageparams": [],
        "link": "",
        "object_type": "files",
        "object_id": 2210,
        "object_name": "",
        "subject_prepared": "You received a new federated share <parameter>lorem.txt</parameter> from <federated-cloud-id display-name=\"Alice@…\" user=\"Alice\" server=\"http://localhost/core\">Alice@http://localhost/core</federated-cloud-id>",
        "message_prepared": "",
        "typeicon": "icon-shared",
        "datetime": "2022-06-28T07:14:30+00:00"
      },
    ]
  }
}

Server configuration

Where did you install ownCloud from: Latest github master

@grgprarup grgprarup changed the title [QA] Expired federated share has wrong activity message on sharee activity Expired federated share has wrong activity message on sharee activity Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant