Check if we have a proper fileinfo #14437
Conversation
|
Makes sense 👍 |
| @@ -60,11 +64,21 @@ public function __construct($root, $view, $path) { | |||
| /** | |||
| * Returns the matching file info | |||
| * | |||
| * @return \OCP\Files\FileInfo | |||
| * @return FileInfo | |||
| * @throws InvalidPathException | |||
There was a problem hiding this comment.
PHPDoc on the interface has to be adjusted as well - behavior-wise a breaking change which has to be documented in the 8.1 features wiki - https://github.com/owncloud/core/wiki/ownCloud-8.1-Features#public-api
There was a problem hiding this comment.
@icewind1991 This needs to be addressed ;)
|
Do unit tests cover this case? THX |
|
According to this message, this doesn't fix the problem
|
|
@icewind1991 please have a look - THX |
That error message does not match up with the code in this pr |
|
@DeepDiver1975 - Probably because the patch was applied on |
icewind1991
force-pushed
the
node-check-fileinfo
branch
from
be6ae7b
to
f5befbe
Compare
|
Added unit test |
|
correct, i applied the change to stable8 |
🙈 |
|
Actually push unit test.... |
|
The inspection completed: 3 new issues, 2 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
Beside my comment above: 👍 |
|
👍 |
Check if we have a proper fileinfo
|
we need a backport pr for stable8 @nickvergessen can you please help out here? THX |
|
@karlitschek backport requested because original issue was reported against oc8 - THX |
|
backport is fine |
|
Backport is in #14568 |
Fixes #14390
cc @PVince81 @oparoz