Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing mysql master tests #14502

Merged
merged 4 commits into from
Feb 26, 2015
Merged

Failing mysql master tests #14502

merged 4 commits into from
Feb 26, 2015

Conversation

nickvergessen
Copy link
Contributor

@DeepDiver1975 @LukasReschke

Fixes multiple failures that each on itself can cause the tests to fail.
At least the group/manager.php change should probably be backported.

@nickvergessen nickvergessen added this to the 8.1-next milestone Feb 25, 2015
@DeepDiver1975
Copy link
Member

@nickvergessen

OCA\Provisioning_API\Tests\GroupsTest::testGetGroupAsSubadmin
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    'users' => Array (...)
+    0 => Array (...)
 )

/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/provisioning_api/tests/groupstest.php:66

@nickvergessen
Copy link
Contributor Author

Should be fixed now

@scrutinizer-notifier
Copy link

The inspection completed: 1 updated code elements

@ghost
Copy link

ghost commented Feb 26, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9980/
Test PASSed.

@LukasReschke
Copy link
Member

As discussed 👍

@DeepDiver1975
Copy link
Member

👍

DeepDiver1975 added a commit that referenced this pull request Feb 26, 2015
@DeepDiver1975
Merge pull request #14502 from owncloud/failing-mysql-master-tests
adc986f 
Failing mysql master tests
@DeepDiver1975 DeepDiver1975 merged commit adc986f into master Feb 26, 2015
@DeepDiver1975 DeepDiver1975 deleted the failing-mysql-master-tests branch February 26, 2015 09:48
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @DeepDiver1975 @scrutinizer-notifier @LukasReschke