Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swallow errors in console.php #14608

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Don't swallow errors in console.php #14608

merged 1 commit into from
Mar 2, 2015

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Feb 28, 2015

In the current implementation, console.php swallows unhandled exceptions instead of propagating an error to the calling shell.
This makes error handling in scripts difficult.

I agree to license this commit under the MIT license as well as AGPL as required.

@ghost
Copy link

ghost commented Feb 28, 2015

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@LukasReschke
Copy link
Member

@owncloud-bot This is okay to test.

@LukasReschke
Copy link
Member

cc @DeepDiver1975 Please review. You know more about that script than me 😄

@RobinMcCorkell
Copy link
Member

👍 This will definitely help integrating occ with external scripts.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@karlitschek
Copy link
Contributor

I agree. 👍 @DeepDiver1975 What do you think?

@LukasReschke
Copy link
Member

@owncloud-bot Retest this please.

@ghost
Copy link

ghost commented Feb 28, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10091/
Test PASSed.

@MorrisJobke MorrisJobke added this to the 8.1-current milestone Mar 1, 2015
DeepDiver1975 added a commit that referenced this pull request Mar 2, 2015
Don't swallow errors in console.php
@DeepDiver1975 DeepDiver1975 merged commit 9c79b1f into owncloud:master Mar 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants