Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron has to be executed with the correct user #15353

Merged
merged 1 commit into from
Apr 1, 2015

Conversation

DeepDiver1975
Copy link
Member

the same approach as in #13282

We need to cleanup this - we are duplicating too much stuff here.

Choosing simple approach to allow backport

@karlitschek @MorrisJobke @schiesbn please review - THX

@DeepDiver1975 DeepDiver1975 added this to the 8.1-current milestone Apr 1, 2015
@DeepDiver1975 DeepDiver1975 changed the title Cron has to be executed with the correct user - fixes 13912 and others Cron has to be executed with the correct user Apr 1, 2015
@scrutinizer-notifier
Copy link

A new inspection was created.

@DeepDiver1975
Copy link
Member Author

fixes #15353, #15299 (comment)

@MorrisJobke
Copy link
Contributor

Works 👍

@RobinMcCorkell
Copy link
Member

The owner of config.php is not necessarily the web server user... Can you check something that is generated by ownCloud, like data/.ocdata?

@ghost
Copy link

ghost commented Apr 1, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11128/
🚀 Test PASSed.🚀
chuck

@MorrisJobke
Copy link
Contributor

The owner of config.php is not necessarily the web server user... Can you check something that is generated by ownCloud, like data/.ocdata?

But it should.

@RobinMcCorkell
Copy link
Member

@MorrisJobke Why? The requirement is that the web server user can write the config.php, not that it owns it.

@MorrisJobke
Copy link
Contributor

@MorrisJobke Why? The requirement is that the web server user can write the config.php, not that it owns it.

true story ... sorry.

@DeepDiver1975
Copy link
Member Author

This is the check we have in place for the console as well since oc8.
I'd prefer to get this in now as well and backport this - further enhancments (not to be backported) will go in a second step into master only.

@Xenopathic sounds reasonable?

@RobinMcCorkell
Copy link
Member

@DeepDiver1975 OK, that sounds reasonable 😄

Code looks good 👍

MorrisJobke added a commit that referenced this pull request Apr 1, 2015
…r-master

Cron has to be executed with the correct user
@MorrisJobke MorrisJobke merged commit 8001f2a into master Apr 1, 2015
@MorrisJobke MorrisJobke deleted the run-cron-with-the-correct-user-master branch April 1, 2015 13:32
@DeepDiver1975
Copy link
Member Author

@karlitschek backport? THX

@karlitschek
Copy link
Contributor

please backport. this is important

@DeepDiver1975
Copy link
Member Author

@MorrisJobke @nickvergessen some spare time to prepare the PR for me? THX a lot!

@MorrisJobke
Copy link
Contributor

stable8 #15369

@MorrisJobke
Copy link
Contributor

stable7 #15370

@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants