Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

usernames should be queried case insensitive #73

Closed
butonic opened this issue Jul 30, 2020 · 2 comments · Fixed by #74
Closed

usernames should be queried case insensitive #73

butonic opened this issue Jul 30, 2020 · 2 comments · Fixed by #74
Assignees
Labels
bug Something isn't working

Comments

@butonic
Copy link
Member

butonic commented Jul 30, 2020

➜  core git:(testFixOCISPR409) ✗ micro call com.owncloud.api.accounts AccountsService.ListAccounts "{\"query\":\"on_premises_sam_account_name eq 'Alice' or mail eq 'Alice'\"}"{        "accounts": [
                {
                        "id": "Alice",
                        "account_enabled": true,
                        "display_name": "Alice Hansen",
                        "preferred_name": "Alice",
                        "mail": "alice@example.org",
                        "password_profile": {},
                        "on_premises_sam_account_name": "Alice"                }        ]}
➜  core git:(testFixOCISPR409) ✗ micro call com.owncloud.api.accounts AccountsService.ListAccounts "{\"query\":\"on_premises_sam_account_name eq 'alice' or mail eq 'alice'\"}"
{}
@butonic butonic self-assigned this Jul 30, 2020
@butonic butonic added the bug Something isn't working label Jul 30, 2020
@phil-davis
Copy link
Contributor

FYI usernames are not case-sensitive in oC10 at all. You can create user Alice and then do API calls to see files, share files,... and refer to the user as Alice alice ALICE ... and modify/delete the user using any mixed-case.

The various OCIS implementations of APIs need to do the same, otherwise we can end up with users Alice alice and ALICE and plenty of confusion when they share resources...

@butonic
Copy link
Member Author

butonic commented Jul 31, 2020

there is a difference between username and userid. while usernames are not case sensitive, userids are. I need to fix this pr before we will see the implications for the test suite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants