Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Better log level handling within micro #2

Closed
tboerger opened this issue Dec 6, 2019 · 1 comment · Fixed by #3
Closed

Better log level handling within micro #2

tboerger opened this issue Dec 6, 2019 · 1 comment · Fixed by #3
Labels
enhancement New feature or request
Milestone

Comments

@tboerger
Copy link
Contributor

tboerger commented Dec 6, 2019

Currently every log message from the micro internals are logged with the info level, we really need to respect the proper defined log level within our log wrapper package.

@tboerger tboerger added the enhancement New feature or request label Dec 6, 2019
@tboerger tboerger added this to the v1.1.0 milestone Dec 6, 2019
@tboerger
Copy link
Contributor Author

tboerger commented Dec 6, 2019

If we log messages from github.com/micro/go-micro/util/log it should behave like the below:

log.Debug("Debug")
log.Error("Error")
log.Info("Info")
log.Warn("Warn")
log.Trace("Trace")
log.Fatal("Fatal")
2019-12-06T09:26:10+01:00 DBG Debug service=ocis
2019-12-06T09:26:10+01:00 ERR Error service=ocis
2019-12-06T09:26:10+01:00 INF Info service=ocis
2019-12-06T09:26:10+01:00 WRN Warn service=ocis
2019-12-06T09:26:10+01:00 DBG Trace service=ocis
2019-12-06T09:26:10+01:00 FTL Fatal service=ocis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant