Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accounts service locking #966

Closed
fschade opened this issue Nov 27, 2020 · 4 comments · Fixed by #1212
Closed

Remove accounts service locking #966

fschade opened this issue Nov 27, 2020 · 4 comments · Fixed by #1212
Assignees
@fschade
Labels
Category:Defect Existing functionality is not working as expected Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Type:Technical-Debt

Comments

@fschade
Copy link
Contributor

fschade commented Nov 27, 2020 •
edited
Loading

The accounts service locks on every request. This can ba a bottleneck in situation with lots of load.
Plan is it to investigate some time why this happened in the past and move locking to the responsible storage implementations.

history: owncloud/ocis-accounts#82
@fschade fschade self-assigned this Nov 27, 2020
@refs
Copy link
Member

refs commented Jan 12, 2021

adding a help-wanted label since it needs to be brought up in the near future in order not to shoot ourselves in the foot.

@settings settings bot removed the help wanted label Jan 12, 2021
@fschade
Copy link
Contributor Author

fschade commented Jan 12, 2021 •
edited
Loading

I already started to optimize, but haven’t found the time to finalize it. It can be found here: #1212

@refs refs added Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Category:Defect Existing functionality is not working as expected Type:Technical-Debt labels Jan 13, 2021
@fschade fschade mentioned this issue Jan 14, 2021
Merged
@fschade
Copy link
Contributor Author

fschade commented Jan 14, 2021

@refs , PR is done, after ci is green we can merge it

@fschade
Copy link
Contributor Author

fschade commented Jan 19, 2021

@refs , merged. Thanks for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fschade fschade

Labels
Category:Defect Existing functionality is not working as expected Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Type:Technical-Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup locking, add named mutex and make cache atomically owncloud/ocis
2 participants
@refs @fschade