Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder upload fails due to broken order of actions #3351

Closed
LukasHirt opened this issue Apr 20, 2020 · 4 comments
Closed

Folder upload fails due to broken order of actions #3351

LukasHirt opened this issue Apr 20, 2020 · 4 comments
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working Type:Technical-Debt
Milestone
backlog

Comments

@LukasHirt
Copy link
Contributor

Folder upload sometimes fails because of parent folders not being created before the files are being uploaded.

Currently, we use two different methods for uploading folder:

one in "New" dialogue

https://github.com/owncloud/phoenix/blob/06554bef6ae1881b7646e7d126dbe36ad6e85a66/apps/files/src/mixins.js#L263

the second one in drag and drop

https://github.com/owncloud/phoenix/blob/06554bef6ae1881b7646e7d126dbe36ad6e85a66/apps/files/src/mixins.js#L177

Let's try to unite them.
@LukasHirt LukasHirt added the Type:Bug Something isn't working label Apr 20, 2020
@LukasHirt LukasHirt added this to the backlog milestone Apr 20, 2020
@PVince81 PVince81 mentioned this issue Apr 20, 2020
Merged
@pascalwengerter
Copy link
Contributor

@LukasHirt is this still the case? :)

@LukasHirt
Copy link
Contributor Author

Hmm, need to test that but folder upload hasn't been touched so I don't think it would be solved 🤷

@LukasHirt
Copy link
Contributor Author

Cannot reproduce the bug but I would still keep the ticket for the research if we can unite folder upload dialog and drag and drop underlying logic...

@kulmann kulmann added the Priority:p1-urgent Consider a hotfix release with only that fix label Dec 3, 2021
@pascalwengerter
Copy link
Contributor

Cannot reproduce the bug but I would still keep the ticket for the research if we can unite folder upload dialog and drag and drop underlying logic...

Good idea! Closed as refactoring the upload logic is tracked in the more pressing #5371, linking here for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working Type:Technical-Debt
Projects
No open projects
Web Support Board
Status: Done
Milestone
backlog
Development

No branches or pull requests
3 participants
@kulmann @pascalwengerter @LukasHirt