From 5043e2230ec28748cdf52e7487262c2a7f04337a Mon Sep 17 00:00:00 2001 From: Cameron McHenry Date: Sun, 22 Sep 2024 14:55:36 -0400 Subject: [PATCH] test(linter): add regression test for #5227 --- crates/oxc_linter/src/rules/eslint/no_useless_escape.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/crates/oxc_linter/src/rules/eslint/no_useless_escape.rs b/crates/oxc_linter/src/rules/eslint/no_useless_escape.rs index 294ae9082bfad..116a9adbf042b 100644 --- a/crates/oxc_linter/src/rules/eslint/no_useless_escape.rs +++ b/crates/oxc_linter/src/rules/eslint/no_useless_escape.rs @@ -572,6 +572,7 @@ fn test() { r"/[\&&&\&]/v", // { "ecmaVersion": 2024 }, r"/[[\-]\-]/v", // { "ecmaVersion": 2024 }, r"/[\^]/v", // { "ecmaVersion": 2024 } + r"/[\s\-(]/", // https://github.com/oxc-project/oxc/issues/5227 ]; let fail = vec![ @@ -692,6 +693,12 @@ fn test() { ("let foo = '\\ ';", "let foo = ' ';", None), ("let foo = /\\ /;", "let foo = / /;", None), ("var foo = `\\$\\{{${foo}`;", "var foo = `$\\{{${foo}`;", None), + ( + // https://github.com/oxc-project/oxc/issues/5227 + r"const regex = /(https?:\/\/github\.com\/(([^\s]+)\/([^\s]+))\/([^\s]+\/)?(issues|pull)\/([0-9]+))|(([^\s]+)\/([^\s]+))?#([1-9][0-9]*)($|[\s\:\;\-\(\=])/;", + r"const regex = /(https?:\/\/github\.com\/(([^\s]+)\/([^\s]+))\/([^\s]+\/)?(issues|pull)\/([0-9]+))|(([^\s]+)\/([^\s]+))?#([1-9][0-9]*)($|[\s:;\-(=])/;", + None, + ), ]; Tester::new(NoUselessEscape::NAME, pass, fail).expect_fix(fix).test_and_snapshot();