Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub sync fails for users with expired invite #167

Open
augustuswm opened this issue May 24, 2022 · 0 comments
Open

GitHub sync fails for users with expired invite #167

augustuswm opened this issue May 24, 2022 · 0 comments
Labels
needs fix Currently functionality that is broken

Comments

@augustuswm
Copy link
Contributor

If a user in configs has been invite to the GitHub org in the past, but did not accept their invite and instead has let the invite expire, subsequent attempts to add the user to the organization will fail with 422 errors. This is seen in src/providers.rs:242. Currently this causes the sync function to return early with a failure.

This should likely be changed, as we are left currently with a partially provisioned user. Either the remaining provisioning steps could be run and GitHub access can be left in its current state or be manually triaged, or we can cancel the invite and re-issue upon checking that it is expired.

@augustuswm augustuswm added the needs fix Currently functionality that is broken label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs fix Currently functionality that is broken
Projects
None yet
Development

No branches or pull requests

1 participant