MegaLinter reports 1 error found even when PSScriptAnalyzer reports no errors bug

[james-garriss]

Describe the bug

When MegaLinter runs PSScriptAnalyzer, and PSScriptAnalyzer reports no errors, MegaLinter reports that there were 12 errors.

To Reproduce

1. Create a GitHub repo that uses PowerShell, such as ScubaGear.
2. Create a GitHub Action workflow that uses MegaLinter.
3. Configure it to use PSScriptAnalyzer.

ENABLE_LINTERS:
  - POWERSHELL_POWERSHELL

4. Run the workflow.
5. See that MegaLinter reports that there are 12 errors, but PSScriptAnalyzer actually finds only warnings and informations.

Expected behavior

I would expect MegaLinter to report the sum total number of errors that PSScriptAnalyzer finds, which is 0.

Screenshots

Results can be seen here: https://github.com/cisagov/ScubaGear/actions/runs/7130729734/job/19417770435

[nvuillam]

Probably the warnings trigger a response code 1 ?

What if you ignore such errors ? https://learn.microsoft.com/en-us/powershell/utility-modules/psscriptanalyzer/using-scriptanalyzer?view=ps-modules#suppressing-rules

[james-garriss]

Why would I ignore them? I still want them reported. I just want them to be reported correctly.

[nvuillam]

@james-garriss FYI there is a current PR about powershell errors counting, maybe you'll be interested by the result ? :)

#3318

[james-garriss]

Super cool. Thank you for the heads up and the good work.