From 6cf77ef55e4e610e91bc3b7e9b6e70784c52c4bd Mon Sep 17 00:00:00 2001 From: Keyan Zhang Date: Sat, 9 Apr 2016 15:49:56 -0400 Subject: [PATCH] Ensure validateDOMNesting catches nested body elements --- src/renderers/dom/client/__tests__/validateDOMNesting-test.js | 2 ++ src/renderers/dom/client/validateDOMNesting.js | 1 + 2 files changed, 3 insertions(+) diff --git a/src/renderers/dom/client/__tests__/validateDOMNesting-test.js b/src/renderers/dom/client/__tests__/validateDOMNesting-test.js index e0bdfe959f2bc..dec17ae4ba288 100644 --- a/src/renderers/dom/client/__tests__/validateDOMNesting-test.js +++ b/src/renderers/dom/client/__tests__/validateDOMNesting-test.js @@ -83,5 +83,7 @@ describe('ReactContextValidator', function() { expect(isTagStackValid(['table', 'tr'])).toBe(false); expect(isTagStackValid(['div', 'ul', 'li', 'div', 'li'])).toBe(false); expect(isTagStackValid(['div', 'html'])).toBe(false); + expect(isTagStackValid(['body', 'body'])).toBe(false); + expect(isTagStackValid(['svg', 'foreignObject', 'body', 'p'])).toBe(false); }); }); diff --git a/src/renderers/dom/client/validateDOMNesting.js b/src/renderers/dom/client/validateDOMNesting.js index 431d80fd2d5db..9422a079e1462 100644 --- a/src/renderers/dom/client/validateDOMNesting.js +++ b/src/renderers/dom/client/validateDOMNesting.js @@ -208,6 +208,7 @@ if (__DEV__) { case 'rt': return impliedEndTags.indexOf(parentTag) === -1; + case 'body': case 'caption': case 'col': case 'colgroup':