Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-journal overriding theme syntax highlighting #44

Open
GISmd opened this issue Oct 24, 2018 · 1 comment
Open

vscode-journal overriding theme syntax highlighting #44

GISmd opened this issue Oct 24, 2018 · 1 comment

Comments

@GISmd
Copy link

GISmd commented Oct 24, 2018

Info

  • vscode 1.28.2
  • vscode-journal 0.9.1
  • Windows 10 64bit

Details

I'm experiencing some odd changes in syntax highlighting when vscode-journal is enabled, especially with checkbox lists. Most hyphens (not all) become yellow and and incomplete checkboxe brackets are yellow. This makes them very difficult to see when using a light colored theme.

These changes persist regardless of what theme I am using. Examples below.

Normal syntax highlighting

syntax-vscode-journal

Syntax highlighting with vscode-journal

syntax-normal

@pajoma
Copy link
Owner

pajoma commented Nov 11, 2018

_Most hyphens (not all) become yellow and and incomplete checkboxe brackets are yellow. _
I guess this affects all indented checkbox items, which are not covered by the regular expressions used for syntax highlighting.

This makes them very difficult to see when using a light colored theme.
The syntax highlighting rules are inserted in your user settings. During startup, the extensions checks if the settings are present and adds them if not. If you switch from a dark to a light color mode, you have to update the colors manually. It's a bit complicated, I know, but another solution (using decorators) seems to be too much of an overhead for such a small feature.

How to adapt the settings:
Switch to the user settings and find the section "editor.tokenColorCustomizations". You can either change the colors or remove the following rules for the following scopes:

  • text.html.markdown.journal.task.open.bullet
  • text.html.markdown.journal.task.open.marker
  • text.html.markdown.journal.task.completed.bullet
  • text.html.markdown.journal.task.completed.marker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants