Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on enum34 breaks python 3.7 (and proabably 3.6) - is it possible to make it a conditional dependency #100

Closed
Ancient87 opened this issue Dec 25, 2020 · 2 comments

Comments

@Ancient87
Copy link

What happened?

I was trying to integrate the conjure generated python classes into my Python3.7.5 environment, and hit an issue. It seem that enum34 breaks newer versions of setuptools as discussed in detail here and here. As both conjure-python-client and the generated classes themselves list enum34 as a dependency Installing the package into my project breaks pip.

For now I had to end up manually scripting/editing the dependency in my generated class files, and "vendor" "conjure-python-client" which is clearly not ideal.

What did you want to happen?

Perhaps it would be an easy fix to replace the dependency with a conditional such as '"enum34; python_version < "3.4"'

Many thanks

@Ancient87 Ancient87 changed the title Dependency on enum34 breaks python > 3.7 - is it possible to make it a conditional dependency Dependency on enum34 breaks python 3.7 (and proabably 3.6) - is it possible to make it a conditional dependency Dec 25, 2020
@Latios96
Copy link

Hi,

I have the same issue as you describe.

There is a pull request here fixing this issue, but it was not merged yet.
Would it be possible to merge this pull request? Is there something missing that prevents merging this?

@robert3005
Copy link
Contributor

Fixed in 2.x (there's also conjure-python 4.x that uses it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants