Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust client for pantsd #10061

Closed
benjyw opened this issue Jun 16, 2020 · 3 comments
Closed

Rust client for pantsd #10061

benjyw opened this issue Jun 16, 2020 · 3 comments
Assignees

Comments

@benjyw
Copy link
Sponsor Contributor

benjyw commented Jun 16, 2020

Should greatly improve client overhead, making pants much snappier, and giving a much better user experience.

@stuhood
Copy link
Sponsor Member

stuhood commented Jun 18, 2020

Working on tackling this via #7369 due to the need to port options parsing incrementally.

@stuhood
Copy link
Sponsor Member

stuhood commented Jul 7, 2020

#7369 is paused for now due to the challenges of native deps (which we might eventually be able to remove, but not in the kind of timeframe we'd like for this effort).

In the meantime though, there are things that we can do to de-risk a full port of the client to rust, and to delete some python code that is now used only for pantsd. In particular: we can switch from using our python nailgun client to using the rust nails client. This will involve changing

# Instantiate a NailgunClient.
client = NailgunClient(
port=port,
remote_pid=pid,
ins=self._stdin,
out=self._stdout,
err=self._stderr,
exit_on_broken_pipe=True,
metadata_base_dir=pantsd_handle.metadata_base_dir,
)
to use a type exposed by the native_engine (similar to how we previously exposed the nailgun server).

This relates to #10057, because the python nailgun client does some peculiar things related to trying to delay sending signals to the server which can be made cleaner using async code.

@stuhood stuhood assigned gshuflin and unassigned stuhood Jul 7, 2020
@stuhood
Copy link
Sponsor Member

stuhood commented Nov 25, 2020

This landed in #10865 and again in #11147. Thanks @gshuflin!

@stuhood stuhood closed this as completed Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants