Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoRemoteLibrary/GoFetch do not support packages in subdirectories. #1998

Closed
jsirois opened this issue Aug 15, 2015 · 1 comment
Closed

GoRemoteLibrary/GoFetch do not support packages in subdirectories. #1998

jsirois opened this issue Aug 15, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@jsirois
Copy link
Contributor

jsirois commented Aug 15, 2015

Some repos place all their code in one or more subpackages and this trips up GoFetch recusrsive resolution. Concretely, for a github repo with go code laid out like so:

https://github.com/pantsbuild/golibs/
  rpc/
    rpc.go
  io/
    io.go
  util/
    dir.go
    file.go

Will fail here when GoFetch tries to determine if the repo has its own remote dependencies to fetch. In general GoFetch needs to recursively glob all go files in the exploded zip package dir.

An example of this sort of repo is here: https://github.com/AdRoll/goamz

@jsirois
Copy link
Contributor Author

jsirois commented Aug 19, 2015

Fix is in @ 91f0e27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant