Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Interface Coverage of LegacyAddressMapper #3875

Closed
JieGhost opened this issue Sep 16, 2016 · 2 comments
Closed

Extend Interface Coverage of LegacyAddressMapper #3875

JieGhost opened this issue Sep 16, 2016 · 2 comments
Assignees

Comments

@JieGhost
Copy link
Contributor

When testing v2 engine in master, I found that LegacyAddressMapper does not have scan_build_files method, which is used by a few tasks. To make all integration tests in master pass on v2 engine, we have to extend the interface coverage of LegacyAddressMapper.

As part of the effort, LegacyAddressMapper should be v2 engine backed (similar to LegacyBuildGraph), which means the new scan_build_files method, along with all existing methods, should be implemented using v2 engine directly.

@JieGhost JieGhost self-assigned this Sep 16, 2016
@JieGhost JieGhost added this to the v2 engine/daemon adoption milestone Sep 16, 2016
@JieGhost
Copy link
Contributor Author

This blocks #3740

@JieGhost
Copy link
Contributor Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant