Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine] undefined names in BUILD files trigger a double trace #4530

Closed
baroquebobcat opened this issue Apr 28, 2017 · 2 comments
Closed

[engine] undefined names in BUILD files trigger a double trace #4530

baroquebobcat opened this issue Apr 28, 2017 · 2 comments
Labels

Comments

@baroquebobcat
Copy link
Contributor

I was looking at #4528, and wondered if v2 looked okay with when it hit an undefined name. I think it could be better

v1

$ ./pants --no-print-exception-stacktrace --no-enable-v2-engine list :
Exception caught: (<class 'pants.build_graph.address_lookup_error.AddressLookupError'>)

Exception message: name 'undeclared' is not defined
 while executing BUILD file BuildFile(BUILD.tools, FileSystemProjectTree(/.../pants))
 Loading addresses from '' failed.

v2

$ ./pants --no-print-exception-stacktrace list :
Exception caught: (<class 'pants.build_graph.address_lookup_error.AddressLookupError'>)

Exception message: Build graph construction failed for (SiblingAddresses(directory=u''), Select(Collection.of(HydratedTarget))):
Computing Select(SiblingAddresses(directory=u''), =Collection.of(HydratedTarget))
  Computing Task(<function transitive_hydrated_targets at 0x102116ed8>, SiblingAddresses(directory=u''), =Collection.of(HydratedTarget))
    Computing TransitiveDependencies( =HydratedTarget, =BuildFileAddresses)
      Computing Task(<function addresses_from_address_families at 0x101f771b8>, SiblingAddresses(directory=u''), =BuildFileAddresses)
        Computing Task(<function parse_address_family at 0x101f746e0>, Dir(path=''), =AddressFamily)
          Throw(Failed to parse BUILD.tools:
name 'undeclared' is not defined)

Computing Select(SiblingAddresses(directory=u''), =BuildFileAddresses)
  Computing Task(<function addresses_from_address_families at 0x101f771b8>, SiblingAddresses(directory=u''), =BuildFileAddresses)
    Computing Task(<function parse_address_family at 0x101f746e0>, Dir(path=''), =AddressFamily)
      Throw(Failed to parse BUILD.tools:
name 'undeclared' is not defined)
@stuhood
Copy link
Sponsor Member

stuhood commented Apr 28, 2017

Related to #3695

... or perhaps just a dupe?

@stuhood
Copy link
Sponsor Member

stuhood commented Jun 27, 2017

Dupe.

@stuhood stuhood closed this as completed Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants