From abcb56414848e5f3dc3bfd192e0edc920dc4ed7b Mon Sep 17 00:00:00 2001 From: Filip Skokan Date: Fri, 22 Dec 2023 12:16:23 +0100 Subject: [PATCH] fix: add explicit Accept-Encoding header to http requests fixes #648 --- docs/README.md | 5 ++++- lib/helpers/request.js | 5 ++++- lib/issuer.js | 1 - test/client/client_instance.test.js | 5 +++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/docs/README.md b/docs/README.md index 9d6ada90..c0bcf166 100644 --- a/docs/README.md +++ b/docs/README.md @@ -569,7 +569,10 @@ requests. ```js const DEFAULT_HTTP_OPTIONS = { - headers: { 'User-Agent': `${pkg.name}/${pkg.version} (${pkg.homepage})` }, + headers: { + 'User-Agent': `${pkg.name}/${pkg.version} (${pkg.homepage})`, + 'Accept-Encoding': 'identity', + }, timeout: 3500, }; ``` diff --git a/lib/helpers/request.js b/lib/helpers/request.js index 45e4f881..d3dfda3b 100644 --- a/lib/helpers/request.js +++ b/lib/helpers/request.js @@ -39,7 +39,10 @@ const setDefaults = (props, options) => { }; setDefaults([], { - headers: { 'User-Agent': `${pkg.name}/${pkg.version} (${pkg.homepage})` }, + headers: { + 'User-Agent': `${pkg.name}/${pkg.version} (${pkg.homepage})`, + 'Accept-Encoding': 'identity', + }, timeout: 3500, }); diff --git a/lib/issuer.js b/lib/issuer.js index cc0114ea..3329e889 100644 --- a/lib/issuer.js +++ b/lib/issuer.js @@ -138,7 +138,6 @@ class Issuer { } static async discover(uri) { - const wellKnownUri = resolveWellKnownUri(uri); const response = await request.call(this, { diff --git a/test/client/client_instance.test.js b/test/client/client_instance.test.js index 8466721e..75301038 100644 --- a/test/client/client_instance.test.js +++ b/test/client/client_instance.test.js @@ -210,9 +210,10 @@ describe('Client', () => { state: 'state', scope: 'openid profile email', }), - ).to.eql('https://op.example.com/auth?client_id=identifier&scope=openid%20profile%20email&response_type=code&state=state'); + ).to.eql( + 'https://op.example.com/auth?client_id=identifier&scope=openid%20profile%20email&response_type=code&state=state', + ); }); - }); describe('#endSessionUrl', function () {