diff --git a/bridges/primitives/polkadot-core/Cargo.toml b/bridges/primitives/polkadot-core/Cargo.toml
index 366ee7aa948e..295fb281e9bb 100644
--- a/bridges/primitives/polkadot-core/Cargo.toml
+++ b/bridges/primitives/polkadot-core/Cargo.toml
@@ -12,7 +12,6 @@ workspace = true
[dependencies]
codec = { features = ["derive"], workspace = true }
-parity-util-mem = { optional = true, workspace = true }
scale-info = { features = ["derive"], workspace = true }
serde = { optional = true, features = [
"derive",
@@ -42,7 +41,6 @@ std = [
"codec/std",
"frame-support/std",
"frame-system/std",
- "parity-util-mem",
"scale-info/std",
"serde",
"sp-core/std",
diff --git a/bridges/primitives/polkadot-core/src/parachains.rs b/bridges/primitives/polkadot-core/src/parachains.rs
index d54ee108386e..a8b1cf6eebf4 100644
--- a/bridges/primitives/polkadot-core/src/parachains.rs
+++ b/bridges/primitives/polkadot-core/src/parachains.rs
@@ -32,9 +32,6 @@ use sp_std::vec::Vec;
#[cfg(feature = "std")]
use serde::{Deserialize, Serialize};
-#[cfg(feature = "std")]
-use parity_util_mem::MallocSizeOf;
-
/// Parachain id.
///
/// This is an equivalent of the `polkadot_parachain_primitives::Id`, which is a compact-encoded
@@ -71,7 +68,7 @@ impl From
for ParaId {
#[derive(
PartialEq, Eq, Clone, PartialOrd, Ord, Encode, Decode, RuntimeDebug, TypeInfo, Default,
)]
-#[cfg_attr(feature = "std", derive(Serialize, Deserialize, Hash, MallocSizeOf))]
+#[cfg_attr(feature = "std", derive(Serialize, Deserialize, Hash))]
pub struct ParaHead(pub Vec);
impl ParaHead {
diff --git a/docs/contributor/commands-readme.md b/docs/contributor/commands-readme.md
index 3a0fadc3bb25..52c554cc7098 100644
--- a/docs/contributor/commands-readme.md
+++ b/docs/contributor/commands-readme.md
@@ -24,11 +24,6 @@ By default, the Start and End/Failure of the command will be commented with the
If you want to avoid, use this flag. Go to
[Action Tab](https://github.com/paritytech/polkadot-sdk/actions/workflows/cmd.yml) to see the pipeline status.
-2.`--continue-on-fail` to continue running the command even if something inside a command
-(like specific pallet weight generation) are failed.
-Basically avoids interruption in the middle with `exit 1`
-The pipeline logs will include what is failed (like which runtimes/pallets), then you can re-run them separately or not.
-
3.`--clean` to clean up all yours and bot's comments in PR relevant to `/cmd` commands. If you run too many commands,
or they keep failing, and you're rerunning them again, it's handy to add this flag to keep a PR clean.
diff --git a/docs/contributor/weight-generation.md b/docs/contributor/weight-generation.md
index 77a570c94530..d5b407d5562d 100644
--- a/docs/contributor/weight-generation.md
+++ b/docs/contributor/weight-generation.md
@@ -19,51 +19,53 @@ In a PR run the actions through comment:
To regenerate all weights (however it will take long,
so don't do it unless you really need it), run the following command:
+
```sh
/cmd bench
```
To generate weights for all pallets in a particular runtime(s), run the following command:
+
```sh
/cmd bench --runtime kusama polkadot
```
For Substrate pallets (supports sub-modules too):
+
```sh
/cmd bench --runtime dev --pallet pallet_asset_conversion_ops
```
> **📝 Note**: The action is not being run right-away, it will be queued and run in the next available runner.
-So might be quick, but might also take up to 10 mins (That's in control of Github).
-Once the action is run, you'll see reaction 👀 on original comment, and if you didn't pass `--quiet` -
-it will also send a link to a pipeline when started, and link to whole workflow when finished.
+> So might be quick, but might also take up to 10 mins (That's in control of Github).
+> Once the action is run, you'll see reaction 👀 on original comment, and if you didn't pass `--quiet` -
+> it will also send a link to a pipeline when started, and link to whole workflow when finished.
----
+> **📝 Note**: It will try keep benchmarking even if some pallets failed, with the result of failed/successful pallets.
+>
+> If you want to fail fast on first failed benchmark, add `--fail-fast` flag to the command.
-> **💡Hint #1** : if you run all runtimes or all pallets, it might be that some pallet in the middle is failed
-to generate weights, thus it stops (fails) the whole pipeline.
-> If you want, you can make it to continue running, even if some pallets are failed, add `--continue-on-fail`
-flag to the command. The report will include which runtimes/pallets have failed, then you can re-run
-them separately after all is done.
+---
This way it runs all possible runtimes for the specified pallets, if it finds them in the runtime
+
```sh
/cmd bench --pallet pallet_balances pallet_xcm_benchmarks::generic pallet_xcm_benchmarks::fungible
```
If you want to run all specific pallet(s) for specific runtime(s), you can do it like this:
+
```sh
/cmd bench --runtime bridge-hub-polkadot --pallet pallet_xcm_benchmarks::generic pallet_xcm_benchmarks::fungible
```
-
-> **💡Hint #2** : Sometimes when you run too many commands, or they keep failing and you're rerunning them again,
-it's handy to add `--clean` flag to the command. This will clean up all yours and bot's comments in PR relevant to
-/cmd commands.
+> **💡Hint #1** : Sometimes when you run too many commands, or they keep failing and you're rerunning them again,
+> it's handy to add `--clean` flag to the command. This will clean up all yours and bot's comments in PR relevant to
+> /cmd commands.
```sh
-/cmd bench --runtime kusama polkadot --pallet=pallet_balances --clean --continue-on-fail
+/cmd bench --runtime kusama polkadot --pallet=pallet_balances --clean
```
-> **💡Hint #3** : If you have questions or need help, feel free to tag @paritytech/opstooling (in github comments)
-or ping in [matrix](https://matrix.to/#/#command-bot:parity.io) channel.
+> **💡Hint #2** : If you have questions or need help, feel free to tag @paritytech/opstooling (in github comments)
+> or ping in [matrix](https://matrix.to/#/#command-bot:parity.io) channel.
diff --git a/prdoc/pr_5886.prdoc b/prdoc/pr_5886.prdoc
new file mode 100644
index 000000000000..f5e597281197
--- /dev/null
+++ b/prdoc/pr_5886.prdoc
@@ -0,0 +1,18 @@
+title: Bump some dependencies
+doc:
+- audience: Runtime Dev
+ description: |-
+ This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to their latest version.
+
+ Fixes: https://github.com/paritytech/polkadot-sdk/issues/5870
+crates:
+- name: sc-consensus-babe
+ bump: patch
+- name: pallet-babe
+ bump: patch
+- name: pallet-revive
+ bump: patch
+- name: sp-runtime
+ bump: patch
+- name: bp-polkadot-core
+ bump: major
diff --git a/substrate/client/consensus/babe/src/authorship.rs b/substrate/client/consensus/babe/src/authorship.rs
index 57ee706a04f6..06394b84f470 100644
--- a/substrate/client/consensus/babe/src/authorship.rs
+++ b/substrate/client/consensus/babe/src/authorship.rs
@@ -108,7 +108,8 @@ pub(super) fn secondary_slot_author(
return None
}
- let rand = U256::from((randomness, slot).using_encoded(sp_crypto_hashing::blake2_256));
+ let rand =
+ U256::from_little_endian(&(randomness, slot).using_encoded(sp_crypto_hashing::blake2_256));
let authorities_len = U256::from(authorities.len());
let idx = rand % authorities_len;
diff --git a/substrate/frame/babe/src/mock.rs b/substrate/frame/babe/src/mock.rs
index 4e4052b2b566..d416e31b25f7 100644
--- a/substrate/frame/babe/src/mock.rs
+++ b/substrate/frame/babe/src/mock.rs
@@ -291,7 +291,7 @@ pub fn new_test_ext_with_pairs(
authorities_len: usize,
) -> (Vec, sp_io::TestExternalities) {
let pairs = (0..authorities_len)
- .map(|i| AuthorityPair::from_seed(&U256::from(i).into()))
+ .map(|i| AuthorityPair::from_seed(&U256::from(i).to_little_endian()))
.collect::>();
let public = pairs.iter().map(|p| p.public()).collect();
diff --git a/substrate/frame/revive/src/wasm/runtime.rs b/substrate/frame/revive/src/wasm/runtime.rs
index 485abbfda225..245c91278a7f 100644
--- a/substrate/frame/revive/src/wasm/runtime.rs
+++ b/substrate/frame/revive/src/wasm/runtime.rs
@@ -46,9 +46,7 @@ const MAX_DECODE_NESTING: u32 = 256;
/// Encode a `U256` into a 32 byte buffer.
fn as_bytes(u: U256) -> [u8; 32] {
- let mut bytes = [0u8; 32];
- u.to_little_endian(&mut bytes);
- bytes
+ u.to_little_endian()
}
#[derive(Clone, Copy)]
diff --git a/substrate/frame/sassafras/src/mock.rs b/substrate/frame/sassafras/src/mock.rs
index f145bffa3a05..d2b329e8a2ba 100644
--- a/substrate/frame/sassafras/src/mock.rs
+++ b/substrate/frame/sassafras/src/mock.rs
@@ -89,7 +89,7 @@ pub fn new_test_ext_with_pairs(
with_ring_context: bool,
) -> (Vec, sp_io::TestExternalities) {
let pairs = (0..authorities_len)
- .map(|i| AuthorityPair::from_seed(&U256::from(i).into()))
+ .map(|i| AuthorityPair::from_seed(&U256::from(i).to_big_endian()))
.collect::>();
let authorities: Vec<_> = pairs.iter().map(|p| p.public()).collect();
diff --git a/substrate/primitives/runtime/src/testing.rs b/substrate/primitives/runtime/src/testing.rs
index b4aeda5a0e7a..a4ce4b5fc1a0 100644
--- a/substrate/primitives/runtime/src/testing.rs
+++ b/substrate/primitives/runtime/src/testing.rs
@@ -29,10 +29,7 @@ use crate::{
ApplyExtrinsicResultWithInfo, KeyTypeId,
};
use serde::{de::Error as DeError, Deserialize, Deserializer, Serialize, Serializer};
-use sp_core::{
- crypto::{key_types, ByteArray, CryptoType, Dummy},
- U256,
-};
+use sp_core::crypto::{key_types, ByteArray, CryptoType, Dummy};
pub use sp_core::{sr25519, H256};
use std::{
cell::RefCell,
@@ -79,7 +76,8 @@ impl From for u64 {
impl UintAuthorityId {
/// Convert this authority ID into a public key.
pub fn to_public_key(&self) -> T {
- let bytes: [u8; 32] = U256::from(self.0).into();
+ let mut bytes = [0u8; 32];
+ bytes[0..8].copy_from_slice(&self.0.to_le_bytes());
T::from_slice(&bytes).unwrap()
}
}