Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Pallet macro: pallet::constant should support custom type for metadata #8827

Closed
shaunxw opened this issue May 16, 2021 · 4 comments
Closed

Pallet macro: pallet::constant should support custom type for metadata #8827

shaunxw opened this issue May 16, 2021 · 4 comments

Comments

@shaunxw
Copy link
Contributor

shaunxw commented May 16, 2021

Some native rust types cannot be used in metadata, like &'static [u8], and currently it's represented by &[u8] in metadata like in claims pallet.

pallet::constant should provide a way to configure custom types for metadata. An attribute macro like pallet::constant_type("&[u8]") might be a way to do it.
@shaunxw shaunxw mentioned this issue May 16, 2021
Merged
@gui1117
Copy link
Contributor

gui1117 commented May 18, 2021

#8615 should remove the need for specifying the type if I'm correct.

@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 7, 2021
@gui1117
Copy link
Contributor

gui1117 commented Jul 8, 2021

hopefully will be fixed by #8615

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 8, 2021
@shawntabrizi
Copy link
Member

i believe this should be fixed now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shawntabrizi @shaunxw @gui1117