Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable backend test failure #1308

Closed
jsdw opened this issue Dec 5, 2023 · 4 comments
Closed

Unstable backend test failure #1308

jsdw opened this issue Dec 5, 2023 · 4 comments

Comments

@jsdw
Copy link
Collaborator

jsdw commented Dec 5, 2023

There appears to be a new unstable backend test failure:

https://github.com/paritytech/subxt/actions/runs/7089806307/job/19295367538

I wonder whether this is the result of #1305, or otherwise just another intermittent issue not addressed properly by that.

@lexnv
Copy link
Collaborator

lexnv commented Dec 5, 2023

The test seem to timeout after a very long time, which may happen if:

  • tx finalized hash is older than whatever chainHead has reported
  • chainHead or backend produces a Finalized event; then a NewBlock event for the same hash (out of order)
  • we somehow clear the seen hashes incorrectly, which loses track of the finalized block
    let mut seen_blocks = HashMap::new();

@jsdw
Copy link
Collaborator Author

jsdw commented Dec 6, 2023

Yeahh, lemme look into it a bit; I do feel like it's likely to have been introduced by that recent fix!

@lexnv
Copy link
Collaborator

lexnv commented Dec 12, 2023

@jsdw
Copy link
Collaborator Author

jsdw commented Mar 21, 2024

I think we addressed this now so I'll close and we can re-open if more issues :)

@jsdw jsdw closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants