Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve events subscriptions #141

Closed
4meta5 opened this issue Jul 19, 2020 · 5 comments
Closed

improve events subscriptions #141

4meta5 opened this issue Jul 19, 2020 · 5 comments

Comments

@4meta5
Copy link
Contributor

4meta5 commented Jul 19, 2020

Might be nice to have a higher level api for subscribing to a particular event type and doing the decoding, but no need for this PR

_Originally posted by @ascjones in #126 (comment)

We need an iterator-like API for subscribing to events for @sunshine-protocol CC @dvc94ch

@dvc94ch
Copy link
Contributor

dvc94ch commented Jul 20, 2020

@ascjones any progress on dynamic event decoding using scale-info?

@ascjones
Copy link
Contributor

No. It depends on integrating scale-info with substrate which I haven't even started yet. I'm busy with ink! 3.0 work atm but will see if I can block out some time to look into it.

@dvc94ch
Copy link
Contributor

dvc94ch commented Jul 31, 2020

Any progress? We need more sophisticated event subscriptions, and without this, they won't work very reliably.

@ascjones
Copy link
Contributor

ascjones commented Aug 7, 2020

@dvc94ch I've started experimenting with this: I'm part way through implementing SCALE encoding for scale-info here: paritytech/scale-info#19.

I'll do some more on it next week and let you know how I progress.

@jsdw
Copy link
Collaborator

jsdw commented May 24, 2022

We have this now, and in the not distant future we'll start relyong on scale_value and so may provide back Value's for unknown events rather than skipping over the bytes, for more flexibility (but also for more robust/deduplicated decode logic)

@jsdw jsdw closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants