Phase::Finalization and Phase::Initialization events silently ignored

[kylezs]

In subscription.rs there is this line:

if let Phase::ApplyExtrinsic(i) = phase {

And then there is no else. for the other event phases.

Took me a while to work out why I wasn't seeing some events being read from our chain, and it's because of this line.

Why are the Phase::Finalized and Phase::Initialization events ignored?

[kylezs]

Just noticed there's this PR open: #283
Though doesn't look the diff actually does anything to solve the issue

[sander2]

Just noticed there's this PR open: #283 Though doesn't look the diff actually does anything to solve the issue

It does address it: notice that self.events.push_back(event); is performed outside of the if let Phase::ApplyExtrinsic(i) = phase {

[jsdw]

I believe that this is now closed by #321, so I'll close this for now (please feel free to re-open if I'm mistaken)