Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nimbus session keys #1062

Closed
RomarQ opened this issue May 16, 2023 · 2 comments · Fixed by #1063
Closed

Support nimbus session keys #1062

RomarQ opened this issue May 16, 2023 · 2 comments · Fixed by #1063

Comments

@RomarQ
Copy link
Contributor

RomarQ commented May 16, 2023

Is your feature request related to a problem? Please describe.

Related issue: #789

Currently I am facing the same problem described in the issue linked above, unfortunately the issue was closed without describing a solution.

I've integrated nimbus framework into a parachain, where session keys now contain a nimbus field to identify the nimbus consensus keys. The issue is that zombienet replaces the genesis session keys configuration with some zombienet specific structure where a nimbus key is not provided.

Is there any easy way to fix this issue, without passing the chain_spec directly or adding nimbus field to this struct (orchestrator/src/chainSpec.ts)?

Describe the solution you'd like

Reuse nimbus field (or any fields unknown by zombienet) when overriding the session.key config.

Original spec:

"session": {
        "keys": [
          [
            "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
            "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
            {
              "nimbus": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY"
            }
          ]
        ]
      },

After zombienet overrides:

"session": {
        "keys": [
          [
            "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
            "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
            {
              "grandpa": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "babe": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "im_online": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "parachain_validator": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "authority_discovery": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "para_validator": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "para_assignment": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "beefy": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "aura": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY",
              "nimbus": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY"
            }
          ]
        ]
      },

Describe alternatives you've considered

Adding nimbus field here: (orchestrator/src/chainSpec.ts)

Additional context

No response

@pepoviola
Copy link
Collaborator

pepoviola commented May 16, 2023

Hi @RomarQ, does nimbus use the same key scheme sr25519? And also should be only added for collators. In general we use the parachains registry to override this behavior, but I think we can add nimbus since could be multiple parachains that want to use it.
Thanks!!

@RomarQ
Copy link
Contributor Author

RomarQ commented May 16, 2023

Hi @pepoviola,

Yes, it uses the same key scheme. Here is the PR with the fix: #1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants