From fb36c606a464eb487ccc8aa72c0ed9c3f3f48d16 Mon Sep 17 00:00:00 2001 From: Javier Viola Date: Wed, 17 May 2023 14:25:24 -0300 Subject: [PATCH 1/2] clean cache before save network info --- javascript/packages/orchestrator/src/network.ts | 6 ++++++ javascript/packages/orchestrator/src/networkNode.ts | 4 ++++ javascript/packages/orchestrator/src/orchestrator.ts | 2 ++ 3 files changed, 12 insertions(+) diff --git a/javascript/packages/orchestrator/src/network.ts b/javascript/packages/orchestrator/src/network.ts index fb4ddaa7c..fe091380d 100644 --- a/javascript/packages/orchestrator/src/network.ts +++ b/javascript/packages/orchestrator/src/network.ts @@ -377,4 +377,10 @@ export class Network { }, ); } + + cleanMetricsCache() { + for( const node of Object.values(this.nodesByName)) { + node.cleanMetricsCache(); + } + } } diff --git a/javascript/packages/orchestrator/src/networkNode.ts b/javascript/packages/orchestrator/src/networkNode.ts index 18c15df09..d17e9ef1d 100644 --- a/javascript/packages/orchestrator/src/networkNode.ts +++ b/javascript/packages/orchestrator/src/networkNode.ts @@ -542,6 +542,10 @@ export class NetworkNode implements NetworkNodeInterface { return spanNames; } + cleanMetricsCache() { + this.cachedMetrics = undefined; + } + // prevent to search in the same log line twice. _dedupLogs( logs: string[], diff --git a/javascript/packages/orchestrator/src/orchestrator.ts b/javascript/packages/orchestrator/src/orchestrator.ts index faac888e3..ac94e7181 100644 --- a/javascript/packages/orchestrator/src/orchestrator.ts +++ b/javascript/packages/orchestrator/src/orchestrator.ts @@ -514,6 +514,8 @@ export async function start( `\t 🚀 LAUNCH COMPLETE under namespace ${decorators.green(namespace)} 🚀`, ); + // clean cache before dump the info. + network.cleanMetricsCache(); await fs.promises.writeFile( `${tmpDir.path}/zombie.json`, JSON.stringify(network), From 6464b04084fd43345e90d4cb873618d46ca21d81 Mon Sep 17 00:00:00 2001 From: Javier Viola Date: Wed, 17 May 2023 14:31:37 -0300 Subject: [PATCH 2/2] fmt --- javascript/packages/orchestrator/src/network.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/javascript/packages/orchestrator/src/network.ts b/javascript/packages/orchestrator/src/network.ts index fe091380d..365e72170 100644 --- a/javascript/packages/orchestrator/src/network.ts +++ b/javascript/packages/orchestrator/src/network.ts @@ -379,8 +379,8 @@ export class Network { } cleanMetricsCache() { - for( const node of Object.values(this.nodesByName)) { - node.cleanMetricsCache(); + for (const node of Object.values(this.nodesByName)) { + node.cleanMetricsCache(); } } }