From 43a9a904c9a2cbb60e4ad4730b9b360616ae018e Mon Sep 17 00:00:00 2001 From: Javier Viola Date: Wed, 18 Oct 2023 10:15:39 -0300 Subject: [PATCH 1/2] fix(test-runner): fix logic for equals 0 desired value and timeout --- javascript/packages/orchestrator/src/networkNode.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/packages/orchestrator/src/networkNode.ts b/javascript/packages/orchestrator/src/networkNode.ts index 99b9fe238..d906d1102 100644 --- a/javascript/packages/orchestrator/src/networkNode.ts +++ b/javascript/packages/orchestrator/src/networkNode.ts @@ -276,7 +276,7 @@ export class NetworkNode implements NetworkNodeInterface { ]); if (resp instanceof Error) { // use `undefined` metrics values in `equal` comparisons as `0` - if (timedout && comparator === "equal" && desiredMetricValue === 0) + if (timedout && comparator === "equal" && desiredMetricValue === 0 && value === undefined) value = 0; else throw resp; } From bfc2e088112075e88f8a8e4243b2abbe21abc723 Mon Sep 17 00:00:00 2001 From: Javier Viola Date: Wed, 18 Oct 2023 10:29:48 -0300 Subject: [PATCH 2/2] fmt --- javascript/packages/orchestrator/src/networkNode.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/javascript/packages/orchestrator/src/networkNode.ts b/javascript/packages/orchestrator/src/networkNode.ts index d906d1102..1009711f8 100644 --- a/javascript/packages/orchestrator/src/networkNode.ts +++ b/javascript/packages/orchestrator/src/networkNode.ts @@ -276,7 +276,12 @@ export class NetworkNode implements NetworkNodeInterface { ]); if (resp instanceof Error) { // use `undefined` metrics values in `equal` comparisons as `0` - if (timedout && comparator === "equal" && desiredMetricValue === 0 && value === undefined) + if ( + timedout && + comparator === "equal" && + desiredMetricValue === 0 && + value === undefined + ) value = 0; else throw resp; }