Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume tokens: Select #10011

Closed
Tracked by #9984
tlabaj opened this issue Jan 16, 2024 · 8 comments
Closed
Tracked by #9984

Consume tokens: Select #10011

tlabaj opened this issue Jan 16, 2024 · 8 comments

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 16, 2024

Depends on #9985 and #9986

Copy link

stale bot commented Mar 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 8, 2024

No react changes required.

cc @patternfly/design-reviewers @patternfly/core-in-react-reviewers to verify.

@andrew-ronaldson
Copy link
Collaborator

Screenshot 2024-04-09 at 4 47 10 PM
Noticing these rounded corners on typeahead selects

@mcoker
Copy link
Contributor

mcoker commented Apr 9, 2024

labels touching the edge of the container
Screenshot 2024-04-09 at 2 50 03 PM

Double blue border - the menu toggle's expanded styling and the focus ring on the inner text input. @andrew-ronaldson @lboehling wdyt, does this styling look ok or should we make some changes?
Screenshot 2024-04-09 at 2 49 25 PM

I think these and @andrew-ronaldson's comment are core issues. Opened a core issue for these - patternfly/patternfly#6536

React select LGTM!

@andrew-ronaldson
Copy link
Collaborator

Do we need to leave this open to double check the core changes?

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 15, 2024

I think we can leave it open for that, especially if the core changes need react followup.

@tlabaj
Copy link
Contributor Author

tlabaj commented Jun 4, 2024

@andrew @kmcfaul can we close this one?

@andrew-ronaldson
Copy link
Collaborator

I think this can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants