Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 still used throughout react #10904

Closed
evwilkin opened this issue Sep 4, 2024 · 0 comments · Fixed by #10968
Closed

v5 still used throughout react #10904

evwilkin opened this issue Sep 4, 2024 · 0 comments · Fixed by #10968
Assignees
Labels
P1 ⭐ top priority issues

Comments

@evwilkin
Copy link
Member

evwilkin commented Sep 4, 2024

v5 is still hard coded into many React files, most frequently in example markdown files in the cssPrefix front matter causing the CSS tables not to generate correctly at the bottom of those react docs pages, but also used within some component code such as the Th component where an old v5 screen reader class is applied, causing the screen reader text content to be visible on the page:

https://github.com/patternfly/patternfly-react/blob/v6/packages/react-table/src/components/Table/Th.tsx#L233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 ⭐ top priority issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants